Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple process option for pfc_gen.py #14710

Conversation

lipxu
Copy link
Contributor

@lipxu lipxu commented Sep 24, 2024

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.

How did you do it?

Add an option "-m" for multiple process for pfc_gen.py.

How did you verify/test it?

mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit a17d205 into sonic-net:master Sep 25, 2024
16 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Sep 25, 2024
What is the motivation for this PR?
Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.

How did you do it?
Add an option "-m" for multiple process for pfc_gen.py.

How did you verify/test it?
mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #14735

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Sep 25, 2024
What is the motivation for this PR?
Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.

How did you do it?
Add an option "-m" for multiple process for pfc_gen.py.

How did you verify/test it?
mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #14736

mssonicbld pushed a commit that referenced this pull request Sep 26, 2024
What is the motivation for this PR?
Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.

How did you do it?
Add an option "-m" for multiple process for pfc_gen.py.

How did you verify/test it?
mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
mssonicbld pushed a commit that referenced this pull request Sep 26, 2024
What is the motivation for this PR?
Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.

How did you do it?
Add an option "-m" for multiple process for pfc_gen.py.

How did you verify/test it?
mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
What is the motivation for this PR?
Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.

How did you do it?
Add an option "-m" for multiple process for pfc_gen.py.

How did you verify/test it?
mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
hdwhdw pushed a commit to hdwhdw/sonic-mgmt that referenced this pull request Oct 10, 2024
What is the motivation for this PR?
Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.

How did you do it?
Add an option "-m" for multiple process for pfc_gen.py.

How did you verify/test it?
mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
vikshaw-Nokia pushed a commit to vikshaw-Nokia/sonic-mgmt that referenced this pull request Oct 23, 2024
What is the motivation for this PR?
Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.

How did you do it?
Add an option "-m" for multiple process for pfc_gen.py.

How did you verify/test it?
mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants