-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple process option for pfc_gen.py #14710
Merged
StormLiangMS
merged 2 commits into
sonic-net:master
from
lipxu:20240924_publicMaster_pfcwd_multipleProcess
Sep 25, 2024
Merged
Add multiple process option for pfc_gen.py #14710
StormLiangMS
merged 2 commits into
sonic-net:master
from
lipxu:20240924_publicMaster_pfcwd_multipleProcess
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StormLiangMS
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 25, 2024
What is the motivation for this PR? Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases. With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes. How did you do it? Add an option "-m" for multiple process for pfc_gen.py. How did you verify/test it? mellanox: https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07 broadcom: https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd cisco: https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
Cherry-pick PR to 202311: #14735 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 25, 2024
What is the motivation for this PR? Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases. With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes. How did you do it? Add an option "-m" for multiple process for pfc_gen.py. How did you verify/test it? mellanox: https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07 broadcom: https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd cisco: https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
8 tasks
Cherry-pick PR to 202405: #14736 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 26, 2024
What is the motivation for this PR? Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases. With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes. How did you do it? Add an option "-m" for multiple process for pfc_gen.py. How did you verify/test it? mellanox: https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07 broadcom: https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd cisco: https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
mssonicbld
pushed a commit
that referenced
this pull request
Sep 26, 2024
What is the motivation for this PR? Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases. With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes. How did you do it? Add an option "-m" for multiple process for pfc_gen.py. How did you verify/test it? mellanox: https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07 broadcom: https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd cisco: https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases. With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes. How did you do it? Add an option "-m" for multiple process for pfc_gen.py. How did you verify/test it? mellanox: https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07 broadcom: https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd cisco: https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Oct 10, 2024
What is the motivation for this PR? Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases. With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes. How did you do it? Add an option "-m" for multiple process for pfc_gen.py. How did you verify/test it? mellanox: https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07 broadcom: https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd cisco: https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases. With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes. How did you do it? Add an option "-m" for multiple process for pfc_gen.py. How did you verify/test it? mellanox: https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07 broadcom: https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd cisco: https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Using multiple process to enhance the fanout sending package performance to reduce the failure rate for pfcwd cases.
With this enhancement, some pfcwd related cases on broadcom platform would failure sometimes.
How did you do it?
Add an option "-m" for multiple process for pfc_gen.py.
How did you verify/test it?
mellanox:
https://elastictest.org/scheduler/testplan/66f27ab91e021eb2510aba07
broadcom:
https://elastictest.org/scheduler/testplan/66f278da4216a91fd43d97cd
cisco:
https://elastictest.org/scheduler/testplan/66f278920369ccd340b3ea7f
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation